Add F# patch to use live FSharp.Build package.#14183
Closed
crummel wants to merge 2 commits intodotnet:mainfrom
Closed
Add F# patch to use live FSharp.Build package.#14183crummel wants to merge 2 commits intodotnet:mainfrom
crummel wants to merge 2 commits intodotnet:mainfrom
Conversation
crummel
force-pushed
the
fsharpBuildPrebuilt
branch
from
1bdd29d to
089f2e6
Compare
MichaelSimons
requested changes
Jul 21, 2022
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
Chris, We should avoid using patches. Please open an FSharp fix and let it flow in. In the interim, please add this to #14167 so that we can track the projected state we believe we will be in when all of the fixes flow in.
Member
I proactively pulled in your patch as I was already making updates to it. |
Author
|
Superseded by dotnet/fsharp#13544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#2944